-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: adjust the order of springApplicationContextProvider #3439
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3439 +/- ##
=============================================
- Coverage 51.57% 51.54% -0.04%
+ Complexity 3379 3374 -5
=============================================
Files 618 617 -1
Lines 20441 20438 -3
Branches 2564 2564
=============================================
- Hits 10543 10535 -8
- Misses 8839 8841 +2
- Partials 1059 1062 +3
|
@@ -26,9 +28,12 @@ | |||
* @author xingfudeshi@gmail.com | |||
* The type spring application context provider | |||
*/ | |||
public class SpringApplicationContextProvider implements ApplicationContextAware { | |||
public class SpringApplicationContextProvider implements ApplicationContextAware, BeanFactoryPostProcessor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add @author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…cate code
Ⅰ. Describe what this PR did
adjust the order of springApplicationContextProvider so that it can init before the bean of xml.
调整springApplicationContextProvider的顺序以使得他可以在xml的bean之前被调用。同时删除了一些无用的代码
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews