Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: opt the logback's config of seata-server #3760

Merged
merged 7 commits into from
May 22, 2021

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented May 21, 2021

optimize: opt the logback's config of seata-server.
优化seata-server的logback相关的配置。

  1. 修复file-appender中生成的日志文件名,无法读取RPC端口的问题;
  2. 移除之前从spring-boot.jar中复制过来的类,并修改对应的配置;
  3. 移除启动命令的参数:-Dlogback.color.disable-for-bat=true
    (注:之前是用来解决在windows系统中使用seata-server.bat启动时,出现颜色符乱码问题,
    现在使用spring-boot启动项目了,已不存在此问题。)
  4. logback.xml重命名为logback-spring.xml
  5. application.yaml重命名为application.yml;(本人有强迫证,就是想少个字符,哈哈)
  6. logback-spring.xmlapplication.yml中添加的几个原有配置和扩展配置关联起来。使logback相关的部分配置,可以在application.yml中进行配置,方便以后logback的配置在配置中心进行配置。
  7. server模块跳过deploy,即不上传依赖,因为它是一个应用,而不是用来提供依赖的。

@wangliang181230 wangliang181230 requested review from slievrly and funky-eyes and removed request for slievrly May 21, 2021 10:38
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #3760 (0bd623b) into develop (9beea74) will increase coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3760      +/-   ##
=============================================
+ Coverage      41.03%   41.25%   +0.21%     
  Complexity      2946     2946              
=============================================
  Files            659      654       -5     
  Lines          22055    21939     -116     
  Branches        2736     2721      -15     
=============================================
  Hits            9051     9051              
+ Misses         12159    12043     -116     
  Partials         845      845              
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
server/src/main/java/io/seata/server/Server.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/io/seata/server/ServerApplication.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../listener/SystemPropertyLoggerContextListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ack/ExtendedWhitespaceThrowableProxyConverter.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

@wangliang181230 wangliang181230 added this to the 1.5.0 milestone May 21, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the module/server server module label May 22, 2021
@funky-eyes funky-eyes merged commit d374c8c into apache:develop May 22, 2021
@wangliang181230 wangliang181230 deleted the optimize/logback-config branch May 22, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants