-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: opt the logback's config of seata-server
#3760
Merged
funky-eyes
merged 7 commits into
apache:develop
from
wangliang181230:optimize/logback-config
May 22, 2021
Merged
optimize: opt the logback's config of seata-server
#3760
funky-eyes
merged 7 commits into
apache:develop
from
wangliang181230:optimize/logback-config
May 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangliang181230
requested review from
slievrly and
funky-eyes
and removed request for
slievrly
May 21, 2021 10:38
Codecov Report
@@ Coverage Diff @@
## develop #3760 +/- ##
=============================================
+ Coverage 41.03% 41.25% +0.21%
Complexity 2946 2946
=============================================
Files 659 654 -5
Lines 22055 21939 -116
Branches 2736 2721 -15
=============================================
Hits 9051 9051
+ Misses 12159 12043 -116
Partials 845 845
|
slievrly
approved these changes
May 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
approved these changes
May 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize: opt the logback's config of
seata-server
.优化
seata-server
的logback相关的配置。file-appender
中生成的日志文件名,无法读取RPC端口的问题;spring-boot.jar
中复制过来的类,并修改对应的配置;-Dlogback.color.disable-for-bat=true
;(注:之前是用来解决在windows系统中使用
seata-server.bat
启动时,出现颜色符乱码问题,现在使用spring-boot启动项目了,已不存在此问题。)
logback.xml
重命名为logback-spring.xml
;application.yaml
重命名为application.yml
;(本人有强迫证,就是想少个字符,哈哈)logback-spring.xml
与application.yml
中添加的几个原有配置和扩展配置关联起来。使logback
相关的部分配置,可以在application.yml
中进行配置,方便以后logback
的配置在配置中心进行配置。server
模块跳过deploy
,即不上传依赖,因为它是一个应用,而不是用来提供依赖的。