-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the problem that 'store mode' parameter does not take effect #3783
Merged
wangliang181230
merged 4 commits into
apache:develop
from
objcoding:fix-store-mode-priority
Jun 1, 2021
Merged
bugfix: fix the problem that 'store mode' parameter does not take effect #3783
wangliang181230
merged 4 commits into
apache:develop
from
objcoding:fix-store-mode-priority
Jun 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3783 +/- ##
=============================================
- Coverage 40.86% 40.84% -0.02%
+ Complexity 2956 2955 -1
=============================================
Files 662 662
Lines 22310 22308 -2
Branches 2777 2777
=============================================
- Hits 9116 9111 -5
- Misses 12347 12349 +2
- Partials 847 848 +1
|
funky-eyes
approved these changes
May 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
objcoding
force-pushed
the
fix-store-mode-priority
branch
from
May 30, 2021 14:22
d618a19
to
d4c91ee
Compare
funky-eyes
added
module/server
server module
type: bug
Category issues or prs related to bug.
labels
May 30, 2021
funky-eyes
requested review from
wangliang181230,
caohdgege,
l81893521 and
slievrly
May 31, 2021 08:02
wangliang181230
changed the title
bugfix:fix the problem that 'store mode' parameter does not take effect.
bugfix: fix the problem that 'store mode' parameter does not take effect
Jun 1, 2021
slievrly
reviewed
Jun 1, 2021
...rc/main/java/io/seata/spring/boot/autoconfigure/properties/server/store/StoreProperties.java
Show resolved
Hide resolved
wangliang181230
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
After the original store mode is split into session store mode and lock store mode, after old users upgrade to the new version, the store mode in the upgraded system will become invalid.
Solution:
This will make seata better compatible with the old version and more user-friendly upgrades.