optimize: optimize the packaging of seata-server
#3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangliang181230
requested review from
niaoshuai,
funky-eyes,
caohdgege and
slievrly
Codecov Report
@@ Coverage Diff @@
## develop #3794 +/- ##
==========================================
Coverage 40.89% 40.89%
Complexity 2984 2984
==========================================
Files 665 665
Lines 22465 22465
Branches 2794 2794
==========================================
Hits 9188 9188
Misses 12429 12429
Partials 848 848 |
helloworlde
suggested changes
Jun 1, 2021
wangliang181230
commented
Jun 1, 2021
| <exclusions> | ||
| <exclusion> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>seata-compressor-all</artifactId> |
There was a problem hiding this comment.
把几个seata-xxx-all从seata-all中移除掉，使打包时，不会提示error信息。（不影响打包结果）
wangliang181230
changed the title
Dockerfileseata-server
wangliang181230
commented
Jun 2, 2021
wangliang181230
commented
Jun 6, 2021
slievrly
reviewed
Jun 10, 2021
| @@ -200,11 +185,12 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-jar-plugin</artifactId> | |||
| <version>3.0.2</version> | |||
| <version>3.2.0</version> | |||
There was a problem hiding this comment.
无法使用。因为spring-boot-starter-parent是通过<scope>import</scope>的方式引入依赖的。
spring-boot-starter-parent的<properties>是不会引用下来的。
There was a problem hiding this comment.
3.2.0是我从spring-boot-dependencies:2.3.10.RELEASE里拿到的版本。
|
LGTM. |
niaoshuai
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize: optimize the packaging of
seata-server.优化
seata-server的打包方式。一）Dockerfile错误修复：
lib\改正为target\LICENSE-BIN改正为LICENSE.二）打包优化：
Dockerfile也打包进seata-server-*.zip中三）其他优化：
spring-boot-maven-plugin的版本号为${spring-boot.version}，避免打包时打印警告。seata-xxx-all从seata-all中移除掉，避免maven-shade-plugin合并模块成功却提示了错误信息。另外还有一个问题，使用docker运行时，直接结束进程了。因为
seata-server.sh的启动命令改成后台运行了。请懂这块的大佬帮忙修复一下。目前，我自己部署时，使用了
spring-boot化之前的命令在docker中启动的。