-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize the DurationUtil #4056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4056 +/- ##
=============================================
- Coverage 49.44% 49.41% -0.04%
+ Complexity 3750 3745 -5
=============================================
Files 700 700
Lines 23571 23578 +7
Branches 2912 2907 -5
=============================================
- Hits 11654 11650 -4
- Misses 10731 10739 +8
- Partials 1186 1189 +3
|
lightClouds917
suggested changes
Oct 9, 2021
common/src/test/java/io/seata/common/util/DurationUtilTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
lightClouds917
approved these changes
Oct 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caohdgege
reviewed
Oct 11, 2021
caohdgege
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caohdgege
reviewed
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: DurationUtil
Ⅱ. Does this pull request fix one issue?
fixes #4048.