Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: upgrade eureka-clients and xstream dependencies #4453

Merged
merged 6 commits into from
Mar 13, 2022

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Mar 9, 2022

Ⅰ. Describe what this PR did

升级eureka client版本到1.10.17,因为在1.10.16里面使用了xstream的1.4.17版本(这个版本有很多安全漏洞),升级eureka可以同时升级xstream版本到1.4.18

Ⅱ. Does this pull request fix one issue?

fixes #4450

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #4453 (5000330) into develop (90be080) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 5000330 differs from pull request most recent head 9daab1b. Consider uploading reports for the commit 9daab1b to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4453      +/-   ##
=============================================
+ Coverage      48.86%   48.92%   +0.05%     
+ Complexity      4006     4001       -5     
=============================================
  Files            730      730              
  Lines          25272    25245      -27     
  Branches        3126     3118       -8     
=============================================
+ Hits           12350    12351       +1     
+ Misses         11595    11567      -28     
  Partials        1327     1327              
Impacted Files Coverage Δ
...java/io/seata/server/session/SessionCondition.java 84.84% <0.00%> (-9.10%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...in/java/io/seata/server/session/SessionHelper.java 74.71% <0.00%> (-0.57%) ⬇️
...erver/storage/file/session/FileSessionManager.java 56.93% <0.00%> (+0.07%) ⬆️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <0.00%> (+1.61%) ⬆️
...in/java/io/seata/server/session/SessionHolder.java 50.00% <0.00%> (+1.72%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 50.18% <0.00%> (+6.13%) ⬆️

@Bughue Bughue reopened this Mar 10, 2022
@funky-eyes funky-eyes changed the title upgrade eureka-clients and xstream bugfix: upgrade eureka-clients and xstream Mar 12, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 12, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. and removed type: bug Category issues or prs related to bug. labels Mar 12, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: upgrade eureka-clients and xstream dependencies: upgrade eureka-clients and xstream dependencies Mar 13, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit cc9eee8 into apache:develop Mar 13, 2022
Bughue added a commit to Bughue/seata that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker镜像seataio/seata-server:latest里有xstream-1.4.17.jar,有很多安全漏洞
5 participants