-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize : optimize debug log and fix typo #4477
Conversation
还发现有几个类的log.debug有这种情况的,是不是一起在这个pr修了 |
Codecov Report
@@ Coverage Diff @@
## develop #4477 +/- ##
=============================================
- Coverage 49.09% 48.98% -0.11%
+ Complexity 4032 4028 -4
=============================================
Files 730 730
Lines 25278 25281 +3
Branches 3126 3129 +3
=============================================
- Hits 12411 12385 -26
- Misses 11545 11573 +28
- Partials 1322 1323 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
shutdownhook类的单词拼写有误,log.debug也没有判断enable
GlobalSessionRedisServiceImpl的log.debug之前有一些逻辑但都是为了打日志,这个也没有enable判断
Ⅱ. Does this pull request fix one issue?
#4476
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews