-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize : optimize logs when global commit/rollback catch an exception #4880
Conversation
…_timeout_not_remove
…_remove � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java � server/src/main/java/io/seata/server/session/SessionHelper.java
…_remove � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java
…_remove � Conflicts: � server/src/main/java/io/seata/server/session/SessionHelper.java
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #4880 +/- ##
============================================
+ Coverage 48.50% 48.55% +0.05%
- Complexity 4188 4194 +6
============================================
Files 764 764
Lines 26876 26877 +1
Branches 3357 3358 +1
============================================
+ Hits 13036 13051 +15
+ Misses 12453 12436 -17
- Partials 1387 1390 +3
|
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
TC在 RM的commit遇到异常和返回false时的行为不一致,容易发生误解,这个pr只对日志进行优化
Ⅱ. Does this pull request fix one issue?
fixes #4879
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews