feature: support mysql update join sql #4914

renliangyu857 · 2022-09-06T13:00:03Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

support mysql update join sql

Ⅱ. Does this pull request fix one issue?

fixes #4118
fixes #4890

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

MysqlUpdateJoinTest有测试用例

Ⅴ. Special notes for reviews

renliangyu857 · 2022-09-06T13:00:34Z

支持语句：update employees inner join merit on employees.performance = merit.performance set salary = salary + salary * count
实现思路拆分为多张表，分别构造这些表的前后置镜像查询语句，主要考虑查哪些表、查哪些字段、如何查
1）查哪些表解析join表子句，递归解析获得表（SQLUpdateRecognizer#getTableName）
2）查哪些字段解析update join中set子句获得update join的所有需要更新的字段(UpdateRecognizer#getUpdateColumns)，这些字段可能涉及到多张表，需要根据特定的表进行过滤（UpdateExecutor#getItemUpdateColumns）
3）如何查以join表子句作为union 表（eg: employees inner join merit on employees.performance = merit.performance），分别查询不同表所需的数据

！！！暂不支持Oracle和PG数据库update join语法

…' into feature_support_mysql_updatejoin

codecov-commenter · 2022-09-22T12:55:01Z

Codecov Report

Merging #4914 (0af1292) into develop (caeb231) will increase coverage by 0.17%.
The diff coverage is 77.51%.

@@              Coverage Diff              @@
##             develop    #4914      +/-   ##
=============================================
+ Coverage      48.62%   48.80%   +0.17%     
- Complexity      4052     4077      +25     
=============================================
  Files            732      733       +1     
  Lines          25773    25942     +169     
  Branches        3173     3197      +24     
=============================================
+ Hits           12532    12660     +128     
- Misses         11909    11933      +24     
- Partials        1332     1349      +17

Impacted Files	Coverage Δ
...seata/discovery/registry/MultiRegistryFactory.java	`0.00% <ø> (ø)`
...a/io/seata/rm/datasource/exec/ExecuteTemplate.java	`4.87% <0.00%> (-0.68%)`	⬇️
.../seata/rm/datasource/undo/UndoExecutorFactory.java	`75.00% <ø> (ø)`
...core/src/main/java/io/seata/sqlparser/SQLType.java	`0.00% <ø> (ø)`
.../java/io/seata/sqlparser/druid/BaseRecognizer.java	`76.19% <ø> (-0.56%)`	⬇️
.../rm/datasource/exec/BaseTransactionalExecutor.java	`56.47% <57.89%> (+0.54%)`	⬆️
...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java	`71.76% <71.05%> (+2.27%)`	⬆️
...va/io/seata/rm/datasource/exec/UpdateExecutor.java	`80.95% <83.33%> (+9.12%)`	⬆️
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java	`83.33% <83.33%> (ø)`
...ser/druid/postgresql/BasePostgresqlRecognizer.java	`23.21% <84.61%> (+18.56%)`	⬆️
... and 10 more

rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java

lgtm-com · 2022-09-29T15:52:11Z

This pull request introduces 2 alerts when merging 2c73223 into d0f324c - view on LGTM.com

new alerts:

2 for Useless null check

lgtm-com · 2022-09-29T16:28:21Z

This pull request introduces 2 alerts when merging f9314c6 into d0f324c - view on LGTM.com

new alerts:

2 for Useless null check

rm-datasource/src/main/java/io/seata/rm/datasource/exec/mysql/MySQLUpdateJoinExecutor.java

rm-datasource/src/test/java/io/seata/rm/datasource/exec/UpdateJoinExecutorTest.java

test/src/test/java/io/seata/at/mysql/MysqlUpdateJoinTest.java

doubleDimple · 2022-10-03T01:42:10Z

rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java

@@ -134,28 +118,36 @@ private String buildAfterImageSQL(TableMeta tableMeta, TableRecords beforeImage)
        String whereSql = SqlGenerateUtils.buildWhereConditionByPKs(tableMeta.getPrimaryKeyOnlyName(), beforeImage.pkRows().size(), getDbType());
        String suffix = " FROM " + getFromTableInSQL() + " WHERE " + whereSql;


FROM WHERE 是否可以考虑定义成静态常量来使用？

FROM WHERE 是否可以考虑定义成静态常量来使用？

这个pr先不要定义了,刘洋有个pr专门搞这个的 @doubleDimple

这块已有的常量比如where可以直接使用,没有的就先不要专门弄了

rm-datasource/src/main/java/io/seata/rm/datasource/exec/mysql/MySQLUpdateJoinExecutor.java

rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java

doubleDimple · 2022-10-03T01:58:50Z

test/src/test/java/io/seata/at/mysql/MysqlUpdateJoinTest.java

+        druidDataSource.setDriverClassName(mysql_driverClassName);
+        druidDataSource.init();
+    }
+}


本地执行下./mvnw clean install -DskipTests=true -Dcheckstyle.skip=false -Dlicense.skip=false
命令,再执行下代码提交,不然checks不通过

funky-eyes

UpdateJoinExecutorTest.testUpdateJoinUndoLog:64 » NullPointer

lgtm-com · 2022-10-03T08:14:58Z

This pull request introduces 2 alerts when merging c27ee3e into dac8aa8 - view on LGTM.com

new alerts:

2 for Useless null check

lgtm-com · 2022-10-03T15:44:10Z

This pull request introduces 2 alerts when merging 02cb4fa into dac8aa8 - view on LGTM.com

new alerts:

2 for Useless null check

funky-eyes

LGTM Please register pr and author information

rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java

slievrly · 2022-10-12T13:38:07Z

rm-datasource/src/main/java/io/seata/rm/datasource/exec/mysql/MySQLUpdateJoinExecutor.java

+        SQLUpdateRecognizer recognizer = (SQLUpdateRecognizer) sqlRecognizer;
+        String tableNames = recognizer.getTableName();
+        if (StringUtils.isEmpty(tableNames)) {
+            return null;


throw Exceptions with an explicit meaning, otherwise it will result in NPE with an unclear meaning

rm-datasource/src/main/java/io/seata/rm/datasource/exec/mysql/MySQLUpdateJoinExecutor.java

slievrly · 2022-10-12T14:46:38Z

...parser-druid/src/main/java/io/seata/sqlparser/druid/postgresql/BasePostgresqlRecognizer.java

+
+            @Override
+            public boolean visit(SQLSubqueryTableSource x) {
+                //just like: select * from (select * from t)


select SQL statement that seata does not intercept.

l81893521 · 2022-10-13T14:32:51Z

...ery/seata-discovery-core/src/main/java/io/seata/discovery/registry/MultiRegistryFactory.java

+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.


Please do not reformat the code that have nothing to do with this pr.

jsbxyyx · 2022-10-15T05:05:31Z

update ignore join is sub update join
If not support update ignore, please judge the sql, execute plain sql executor.

slievrly

LGTM

jsbxyyx · 2022-10-18T03:38:22Z

seata mysql8，test库中的test1，test2两张表执行如下语句无法回滚。

update test1, test2 set test1.name = '1', test2.name2 = '2xxxxx' where test2.name = '2xx'

CREATE TABLE `test1` (
  `id` bigint(20) NOT NULL AUTO_INCREMENT,
  `name` varchar(255) DEFAULT NULL,
  `name2` varchar(255) DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
insert into test1 values(1,'1',NULL), (2,'1',NULL);


CREATE TABLE `test2` (
  `id` bigint(20) NOT NULL AUTO_INCREMENT,
  `name` varchar(255) DEFAULT NULL,
  `name2` varchar(255) DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
insert into test2 values (1,'2xx','2xxxxx'),(2,'2xx', '2xxxxx');

support mysql update join sql

7ce659d

slievrly added mode: AT AT transaction mode module/rm-datasource rm-datasource module labels Sep 7, 2022

renliangyu857 and others added 2 commits September 7, 2022 15:42

bugfix:compatible with multi update executor

245d59f

Merge branch 'develop' into feature_support_mysql_updatejoin

42c6eb5

slievrly added this to the 1.6.0 milestone Sep 15, 2022

renliangyu857 added 2 commits September 22, 2022 20:42

disable local mysql test

1b357c0

Merge remote-tracking branch 'origin/feature_support_mysql_updatejoin…

f2296b7

…' into feature_support_mysql_updatejoin

funky-eyes reviewed Sep 28, 2022

View reviewed changes

rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java Outdated Show resolved Hide resolved

rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java Outdated Show resolved Hide resolved

add MySQLUpdateJoinExecutor

2c73223

Merge branch 'develop' into feature_support_mysql_updatejoin

f9314c6