feature: support kryo 5.3.0 #4968
Conversation
|
晕 不了解seata源码 改不明白了 |
|
全局依赖版本都替换了 rm-datasource 模块就是找不到..... |
|
@JavaLionLi io.seata.rm.datasource.undo.parser.KryoSerializerFactory io.seata.serializer.kryo.KryoSerializerFactory |
谢谢 找到了 已经更改提交了 |
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(KryoSerializerFactory.class); | ||
|
|
||
| private static final KryoSerializerFactory FACTORY = new KryoSerializerFactory(); | ||
|
|
||
| private KryoPool pool = new KryoPool.Builder(this).softReferences().build(); | ||
| private Pool<Kryo> pool = new Pool<Kryo>(true, true) { |
There was a problem hiding this comment.
Why abandon the previous method of calling?
There was a problem hiding this comment.
? I don't understand what you mean
There was a problem hiding this comment.
why change private KryoPool pool = new KryoPool.Builder(this).softReferences().build(); to private Pool<Kryo> pool = new Pool<Kryo>(true, true) ?
There was a problem hiding this comment.
why change
private KryoPool pool = new KryoPool.Builder(this).softReferences().build();toprivate Pool<Kryo> pool = new Pool<Kryo>(true, true)?
Because 5. X KryoPool was deleted
There was a problem hiding this comment.
why change
private KryoPool pool = new KryoPool.Builder(this).softReferences().build();toprivate Pool<Kryo> pool = new Pool<Kryo>(true, true)?
Replaced by this class
There was a problem hiding this comment.
KryoFactory#create method does not exist in the new version?
There was a problem hiding this comment.
@slievrly yes, 5.3.0 deleted builder api.
Codecov Report
@@ Coverage Diff @@
## develop #4968 +/- ##
=============================================
- Coverage 48.77% 48.76% -0.01%
+ Complexity 4081 4078 -3
=============================================
Files 734 734
Lines 25855 25855
Branches 3190 3191 +1
=============================================
- Hits 12611 12609 -2
- Misses 11900 11902 +2
Partials 1344 1344
|
funky-eyes
added
type: feature
Registration completed |
Ⅰ. Describe what this PR did
升级 kryo依赖到5.X 4.X于2018年停止维护了
Ⅱ. Does this pull request fix one issue?
fixes #4961
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews