bugfix: fix getConfig throw ClassCastException when use JDK proxy
#5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangliang181230
requested review from
slievrly and
funky-eyes
and removed request for
slievrly
wangliang181230
changed the title
getConfig throw CastExceptiongetConfig throw ClassCastException
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5239 +/- ##
=============================================
- Coverage 48.85% 48.70% -0.15%
+ Complexity 4165 4156 -9
=============================================
Files 743 743
Lines 26536 26588 +52
Branches 3301 3320 +19
=============================================
- Hits 12964 12951 -13
- Misses 12164 12239 +75
+ Partials 1408 1398 -10
|
1 task
wangliang181230
added
type: bug
wangliang181230
changed the title
getConfig throw ClassCastExceptiongetConfig throw ClassCastException, and optimize some log
wangliang181230
changed the title
getConfig throw ClassCastException, and optimize some loggetConfig throw ClassCastException on native-image, and optimize some log
wangliang181230
changed the title
getConfig throw ClassCastException on native-image, and optimize some loggetConfig throw ClassCastException when use jdk proxy, and optimize some log
wangliang181230
changed the title
getConfig throw ClassCastException when use jdk proxy, and optimize some loggetConfig throw ClassCastException when use JDK proxy, and optimize some log
slievrly
changed the title
getConfig throw ClassCastException when use JDK proxy, and optimize some loggetConfig throw ClassCastException when use JDK proxy
slievrly
reviewed
Jan 29, 2023
| try { | ||
| result = getDefaultValueFromPropertyObject(dataId); | ||
| } catch (Throwable t) { | ||
| LOGGER.error("Get config '{}' default value from the property object failed:", dataId, t); |
There was a problem hiding this comment.
According to the previous configuration priority, the priority of the value object is greater than the default value priority of the parameter
There was a problem hiding this comment.
The object is no longer a spring bean, so I think the priority is no longer higher than the arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix: fix
getConfigthrowClassCastExceptionwhen use JDK proxy, and optimize some log.BUG修复：修复当使用JDK代理时，
getConfig方法获取部分配置时抛出ClassCastException异常的问题，另外顺便优化了几处日志。Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews