Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: The common fence clean task is only initiated when useTCCFence is set to true #5576

Merged
merged 2 commits into from
May 15, 2023

Conversation

dmego
Copy link
Contributor

@dmego dmego commented May 14, 2023

…nce is set to true

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

优化 TCC fence log 表的清理定时任务开启时机,只有当 useTCCFence = true 时,才进行初始化

Ⅱ. Does this pull request fix one issue?

fixes #5554

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.0.0 milestone May 14, 2023
@funky-eyes
Copy link
Contributor

还要考虑一个问题,后续是否要增加fence表的检测是否存在,否则应用已经启动发布上线了,可能存在故障发生的可能

@funky-eyes funky-eyes added mode: TCC TCC transaction mode module/tcc tcc module type: optimize module/intergration-tx-api intergration-tx-api and removed module/tcc tcc module labels May 14, 2023
@funky-eyes funky-eyes merged commit 0b49e06 into apache:2.x May 15, 2023
@dmego
Copy link
Contributor Author

dmego commented May 15, 2023

@a364176773 之前想的是在应用启动的时候就去做判断,想在 TccActionInterceptorParser 这个类里去实现这块逻辑,但是 debug 发现执行到这个类的方法时,SpringFenceConfig 实例还没加载到容器。所以没想到特别好的方法去处理。

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pil0tXia pushed a commit to Pil0tXia/seata that referenced this pull request Jun 14, 2023
my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: support case-sensitive attributes for table and column metadata (apache#5553) (+14 squashed commit)

Squashed commit:

[c97f409] mychange 1

my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

[8f9bba2] bugfix: fix the `asyncCommit` and `queueToRetryCommit` always failed in db mode (apache#5604)

[b2d4584] bugfix: fix log in participant transaction role (apache#5594)

[d0d012c] feature: support sqlserver in AT mode (apache#3887)

[54bd3ca] feature:support MS SqlServer on the server side of AT mode (apache#4033)

[d1e6e6b] bugfix: grpc interceptor xid unbinding problem (apache#5577)

[0b49e06] optimize: The common fence clean task is only initiated when useTCCFence is set to true (apache#5576)

[7e40e05] bugfix: fix mariadb rollback failed (apache#5558)

[ee1ecf7] bugfix: fix oracle insert undolog failed (apache#5556)

Signed-off-by: slievrly <slievrly@163.com>

[0a1edf3] optimize: update expire gpg key and publish workflow (apache#5549)

Signed-off-by: slievrly <slievrly@163.com>

[1c8e4bf] bugfix: the log file path was loaded incorrectly (apache#5531)

[c73d72d] bugfix: fix GlobalStatus=9 can't be cleared in DB storage mode (apache#5523)

[83493d9] optimize: optimize FenceHandler for oracle (apache#5519)

[9b35ba9] bugfix: fix the full table scan issue with 'setDate' condition in Oracle 10g (apache#5498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: TCC TCC transaction mode module/intergration-tx-api intergration-tx-api type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete fence log failed
3 participants