-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: The common fence clean task is only initiated when useTCCFence is set to true #5576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
还要考虑一个问题,后续是否要增加fence表的检测是否存在,否则应用已经启动发布上线了,可能存在故障发生的可能 |
@a364176773 之前想的是在应用启动的时候就去做判断,想在 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
my change 2 optimize: optimize channel availability thread log output (apache#5563) feature:docker image supports JVM parameter injection (apache#5529) test: add unit test for transaction messages (apache#5637) feature: support trace the transaction link according to the XID (apache#5600) test: add unit test case for ExporterType/RegistryType (apache#5622) optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623) optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623) optimize: support case-sensitive attributes for table and column metadata (apache#5553) (+14 squashed commit) Squashed commit: [c97f409] mychange 1 my change 2 optimize: optimize channel availability thread log output (apache#5563) feature:docker image supports JVM parameter injection (apache#5529) test: add unit test for transaction messages (apache#5637) feature: support trace the transaction link according to the XID (apache#5600) test: add unit test case for ExporterType/RegistryType (apache#5622) [8f9bba2] bugfix: fix the `asyncCommit` and `queueToRetryCommit` always failed in db mode (apache#5604) [b2d4584] bugfix: fix log in participant transaction role (apache#5594) [d0d012c] feature: support sqlserver in AT mode (apache#3887) [54bd3ca] feature:support MS SqlServer on the server side of AT mode (apache#4033) [d1e6e6b] bugfix: grpc interceptor xid unbinding problem (apache#5577) [0b49e06] optimize: The common fence clean task is only initiated when useTCCFence is set to true (apache#5576) [7e40e05] bugfix: fix mariadb rollback failed (apache#5558) [ee1ecf7] bugfix: fix oracle insert undolog failed (apache#5556) Signed-off-by: slievrly <slievrly@163.com> [0a1edf3] optimize: update expire gpg key and publish workflow (apache#5549) Signed-off-by: slievrly <slievrly@163.com> [1c8e4bf] bugfix: the log file path was loaded incorrectly (apache#5531) [c73d72d] bugfix: fix GlobalStatus=9 can't be cleared in DB storage mode (apache#5523) [83493d9] optimize: optimize FenceHandler for oracle (apache#5519) [9b35ba9] bugfix: fix the full table scan issue with 'setDate' condition in Oracle 10g (apache#5498)
…nce is set to true
Ⅰ. Describe what this PR did
优化 TCC fence log 表的清理定时任务开启时机,只有当
useTCCFence = true
时,才进行初始化Ⅱ. Does this pull request fix one issue?
fixes #5554
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews