Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add meta info to docker image #5842

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Sep 11, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Adding meta information to docker image,those information will be helpful for locating problems.

docker image inspect registry.cn-hangzhou.aliyuncs.com/truthai/seata-server:latest
image

Ⅱ. Does this pull request fix one issue?

fixes #5653

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've tested it.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #5842 (5d15518) into 2.x (4a3888b) will increase coverage by 0.03%.
Report is 1 commits behind head on 2.x.
The diff coverage is n/a.

❗ Current head 5d15518 differs from pull request most recent head c24db09. Consider uploading reports for the commit c24db09 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5842      +/-   ##
============================================
+ Coverage     49.00%   49.03%   +0.03%     
- Complexity     4458     4465       +7     
============================================
  Files           821      821              
  Lines         28557    28557              
  Branches       3570     3570              
============================================
+ Hits          13995    14004       +9     
+ Misses        13102    13098       -4     
+ Partials       1460     1455       -5     

see 4 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert to the docker hub registry.

@xingfudeshi
Copy link
Member Author

revert to the docker hub registry.

done

@slievrly slievrly added this to the 2.0.0 milestone Sep 22, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ce2f962 into apache:2.x Sep 22, 2023
6 checks passed
@slievrly slievrly changed the title adding metainfo to docker image optimize: add meta info to docker image Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commit id to docker latest image
2 participants