optimize: fix build action warning #5944
Conversation
| @@ -54,7 +54,7 @@ jobs: | |||
| # step 2 | |||
| - name: "Set up QEMU" | |||
| id: qemu | |||
| uses: docker/setup-qemu-action@v1 | |||
| uses: docker/setup-qemu-action@v3 | |||
There was a problem hiding this comment.
The build_arm64-binary action only works on push events, so there is no way to confirm that this issue has been resolved until this PR merge. Therefore, I propose to temporarily add build_arm64-binary action to pull request in this PR and remove it after confirming that there is no problem.
There was a problem hiding this comment.
https://github.com/leizhiyuan/seata/actions/runs/6582808710/job/17884865374
I will test in my fork
There was a problem hiding this comment.
https://github.com/leizhiyuan/seata/actions/runs/6582999974 (to speed up)
the waring has been resolved, To accelerate the verification process, I mock some command scripts that are unrelated to warnings.
There was a problem hiding this comment.
ok, it seems to be working fine.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5944 +/- ##
============================================
- Coverage 49.77% 49.76% -0.02%
+ Complexity 4543 4540 -3
============================================
Files 854 854
Lines 29880 29880
Branches 3660 3660
============================================
- Hits 14874 14870 -4
- Misses 13517 13519 +2
- Partials 1489 1491 +2 |
|
Does the |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5943
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
run the action
Ⅴ. Special notes for reviews