Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test cases for RaftServerFactory #6009

Merged
merged 13 commits into from
Nov 10, 2023
Merged

test: add test cases for RaftServerFactory #6009

merged 13 commits into from
Nov 10, 2023

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5962

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title test: Adding test cases for RaftServerFactory test: add test cases for RaftServerFactory Nov 9, 2023
@funky-eyes funky-eyes added this to the 2.0.0 milestone Nov 9, 2023
@funky-eyes funky-eyes added module/server server module type: test test case labels Nov 9, 2023
@funky-eyes funky-eyes closed this Nov 9, 2023
@funky-eyes funky-eyes reopened this Nov 9, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #6009 (9e30f76) into 2.x (8fed3d8) will increase coverage by 0.20%.
The diff coverage is 77.77%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6009      +/-   ##
============================================
+ Coverage     49.49%   49.69%   +0.20%     
- Complexity     4754     4779      +25     
============================================
  Files           911      911              
  Lines         31315    31316       +1     
  Branches       3773     3773              
============================================
+ Hits          15499    15563      +64     
+ Misses        14269    14221      -48     
+ Partials       1547     1532      -15
Files Coverage Δ
...io/seata/server/cluster/raft/RaftStateMachine.java 62.50% <100.00%> (+13.19%) ⬆️
...o/seata/server/cluster/raft/RaftServerFactory.java 87.12% <75.00%> (+18.12%) ⬆️

... and 8 files with indirect coverage changes

@funky-eyes funky-eyes closed this Nov 9, 2023
@funky-eyes funky-eyes reopened this Nov 9, 2023
@funky-eyes funky-eyes closed this Nov 9, 2023
@funky-eyes funky-eyes reopened this Nov 9, 2023
@funky-eyes funky-eyes closed this Nov 10, 2023
@funky-eyes funky-eyes reopened this Nov 10, 2023
xingfudeshi
xingfudeshi approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 8192138 into apache:2.x Nov 10, 2023
13 checks passed
liuqiufeng pushed a commit to liuqiufeng/seata that referenced this pull request Nov 10, 2023
@funky-eyes @liuqiufeng
test: add test cases for RaftServerFactory (apache#6009)
55b5ce1
@open-digger-bot open-digger-bot bot mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leizhiyuan leizhiyuan leizhiyuan approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@lovepoem lovepoem Awaiting requested review from lovepoem

@slievrly slievrly Awaiting requested review from slievrly

@l81893521 l81893521 Awaiting requested review from l81893521

Assignees
No one assigned
Labels
module/server server module type: test test case
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Adding test cases for RaftServerFactory
3 participants
@funky-eyes @leizhiyuan @xingfudeshi