Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrade springboot and spring version for server #6052

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

ptyin
Copy link
Member

@ptyin ptyin commented Nov 17, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6051

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #6052 (a3d211f) into 2.x (545da73) will decrease coverage by 0.09%.
Report is 2 commits behind head on 2.x.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6052      +/-   ##
============================================
- Coverage     49.57%   49.49%   -0.09%     
- Complexity     4751     4752       +1     
============================================
  Files           907      908       +1     
  Lines         31295    31354      +59     
  Branches       3773     3777       +4     
============================================
+ Hits          15515    15519       +4     
- Misses        14247    14302      +55     
  Partials       1533     1533              

see 7 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to skip the server module as it is a binary package or image and does not involve adapting to different versions of Spring.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit b6d7159 into apache:2.x Nov 19, 2023
8 checks passed
@slievrly slievrly added this to the 2.0.0 milestone Nov 19, 2023
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly mentioned this pull request Nov 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

springboot3.x (17, 3.1.4 -Dspring-framework.version=6.0.12) UT failed.
3 participants