Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove @author info #6179

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Dec 21, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove @author info

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97b9ad9) 48.99% compared to head (22ba9c5) 48.97%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6179      +/-   ##
============================================
- Coverage     48.99%   48.97%   -0.02%     
+ Complexity     4782     4771      -11     
============================================
  Files           915      915              
  Lines         31865    31863       -2     
  Branches       3847     3849       +2     
============================================
- Hits          15611    15606       -5     
- Misses        14692    14702      +10     
+ Partials       1562     1555       -7     
Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <ø> (ø)
common/src/main/java/io/seata/common/XID.java 92.30% <ø> (ø)
...io/seata/common/exception/DataAccessException.java 100.00% <ø> (ø)
...eata/common/exception/EurekaRegistryException.java 100.00% <ø> (ø)
.../io/seata/common/exception/FrameworkErrorCode.java 94.44% <ø> (ø)
.../io/seata/common/exception/FrameworkException.java 85.18% <ø> (ø)
.../io/seata/common/exception/JsonParseException.java 0.00% <ø> (ø)
...seata/common/exception/NotSupportYetException.java 100.00% <ø> (ø)
... and 159 more

... and 730 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 21, 2023
# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
@lightClouds917
Copy link
Contributor

LGTM

@xingfudeshi xingfudeshi merged commit de9596b into apache:2.x Dec 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants