bugfix: convert to utf8mb4 if mysql column is json type #6232
Conversation
funky-eyes
added
type: bug
| /** | ||
| * the type MySQLJsonHelper | ||
| **/ | ||
| public class MySQLJsonHelper { |
There was a problem hiding this comment.
是不是不叫mysqljsonhelper比较好，应该取一个中型点的名字，专门用来识别datatype拼接sql用，把nonPkFields.stream().map内的逻辑全部挪到此处
Is it better not to call mysqljsonhelper, should take a medium point name, specially used to identify datatype splicing sql, move all the logic in nonPkFields.stream ().map here
There was a problem hiding this comment.
OK,I'll optimize it later.
There was a problem hiding this comment.
Error: /home/runner/work/incubator-seata/incubator-seata/rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoUpdateExecutor.java:62: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
Error: /home/runner/work/incubator-seata/incubator-seata/rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoUpdateExecutor.java:63: 'block' child has incorrect indentation level 20, expected level should be 16. [Indentation]
Error: /home/runner/work/incubator-seata/incubator-seata/rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoUpdateExecutor.java:64: 'block' child has incorrect indentation level 20, expected level should be 16. [Indentation]
Error: /home/runner/work/incubator-seata/incubator-seata/rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoUpdateExecutor.java:65: 'block rcurly' has incorrect indentation level 16, expected level should be 12. [Indentation]
rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoDeleteExecutor.java
Outdated
Show resolved
Hide resolved
…MySQLUndoDeleteExecutor.java
|
Please add changelog |
Bughue
changed the title
Ⅰ. Describe what this PR did
from https://dev.mysql.com/doc/refman/8.0/en/json.html
Ⅱ. Does this pull request fix one issue?
fixes #5107
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews