optimize: build the frontend at the same time as the maven build #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6246 +/- ##
============================================
+ Coverage 51.05% 51.08% +0.03%
- Complexity 5093 5098 +5
============================================
Files 918 918
Lines 32031 32031
Branches 3865 3865
============================================
+ Hits 16353 16363 +10
+ Misses 14101 14095 -6
+ Partials 1577 1573 -4 |
slievrly
reviewed
Jan 11, 2024
slievrly
reviewed
Jan 11, 2024
slievrly
reviewed
Jan 11, 2024
slievrly
reviewed
Jan 11, 2024
None of these changes affect the separate packaging of the console front-end |
slievrly
changed the title
slievrly
reviewed
Jan 16, 2024
| <configuration> | ||
| <workingDirectory>src/main/resources/static/console-fe</workingDirectory> | ||
| </configuration> | ||
| <executions> |
There was a problem hiding this comment.
any phase here ?
Added phase here.
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
slievrly
reviewed
Jan 17, 2024
| @@ -166,6 +169,7 @@ | |||
| <goals> | |||
| <goal>npm</goal> | |||
| </goals> | |||
| <phase>generate-resources</phase> | |||
There was a problem hiding this comment.
it is unreasonable to set it in the generate-resources phase.
There was a problem hiding this comment.
Considering online IDE debugging, maintain the status quo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews