Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: JDBC resultSet, statement and connection closing order #6248

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Jan 8, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes: #6224

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@jsbxyyx jsbxyyx changed the title bugfix: resultSet, statement and connection close sequence bugfix: resultSet, statement and connection closing order Jan 8, 2024
@jsbxyyx jsbxyyx changed the title bugfix: resultSet, statement and connection closing order bugfix: JDBC resultSet, statement and connection closing order Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (2363715) 49.97% compared to head (f1845fa) 49.89%.
Report is 6 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6248      +/-   ##
============================================
- Coverage     49.97%   49.89%   -0.08%     
- Complexity     4928     4939      +11     
============================================
  Files           915      917       +2     
  Lines         31927    32010      +83     
  Branches       3855     3862       +7     
============================================
+ Hits          15954    15972      +18     
- Misses        14406    14477      +71     
+ Partials       1567     1561       -6     
Files Coverage Δ
.../rm/datasource/exec/BaseTransactionalExecutor.java 74.00% <100.00%> (+0.26%) ⬆️
.../seata/rm/datasource/exec/MultiUpdateExecutor.java 80.26% <100.00%> (+0.26%) ⬆️
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 84.09% <100.00%> (+0.36%) ⬆️
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 78.48% <100.00%> (+0.13%) ⬆️
...ec/mysql/MySQLInsertOnDuplicateUpdateExecutor.java 32.16% <0.00%> (-0.17%) ⬇️
...er/console/impl/db/BranchSessionDBServiceImpl.java 0.00% <0.00%> (ø)
...erver/console/impl/db/GlobalLockDBServiceImpl.java 0.00% <0.00%> (ø)
...er/console/impl/db/GlobalSessionDBServiceImpl.java 0.00% <0.00%> (ø)

... and 23 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 8, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Jan 8, 2024
@funky-eyes funky-eyes merged commit cd5d816 into apache:2.x Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
3 participants