feature：init Namingserver server #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md # common/src/main/java/org/apache/seata/common/metadata/Cluster.java # common/src/main/java/org/apache/seata/common/result/Code.java # common/src/main/java/org/apache/seata/common/result/Result.java # common/src/main/java/org/apache/seata/common/result/SingleResult.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6538 +/- ##
============================================
- Coverage 50.46% 50.33% -0.14%
- Complexity 5830 5851 +21
============================================
Files 1051 1058 +7
Lines 36347 36586 +239
Branches 4323 4347 +24
============================================
+ Hits 18342 18414 +72
- Misses 16187 16349 +162
- Partials 1818 1823 +5
|
# Conflicts: # common/src/main/java/org/apache/seata/common/metadata/Node.java
funky-eyes
added
type: feature
funky-eyes
reviewed
Jul 17, 2024
common/src/main/java/org/apache/seata/common/metadata/Unit.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/metadata/MetaResponse.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/metadata/Instance.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Jul 17, 2024
server/src/main/java/org/apache/seata/server/storage/db/store/VGroupMappingDataBaseDAO.java
Show resolved
Hide resolved
funky-eyes
reviewed
Jul 17, 2024
server/src/main/java/org/apache/seata/server/storage/db/store/VGroupMappingDataBaseDAO.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/seata/server/storage/redis/store/RedisVGroupMappingStoreManager.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Jul 17, 2024
.../test/java/org/apache/seata/server/storage/file/store/FileVGroupMappingStoreManagerTest.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Jul 22, 2024
common/src/main/java/org/apache/seata/common/NamingServerConstants.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/NamingServerConstants.java
Outdated
Show resolved
Hide resolved
| import org.springframework.boot.test.context.SpringBootTest; | ||
|
|
||
|
|
||
| @Disabled |
There was a problem hiding this comment.
This test depends on the DB environment.
There was a problem hiding this comment.
This test depends on the DB environment.
为什么不是默认存储在file或者redis，这样也能开启这个测试用例
Why is it not stored in file or redis by default, so that this test case can also be opened?
server/src/main/java/org/apache/seata/server/storage/db/store/VGroupMappingDataBaseDAO.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/seata/server/storage/db/store/DataBaseVGroupMappingStoreManager.java
Show resolved
Hide resolved
funky-eyes
reviewed
Jul 25, 2024
common/src/main/java/org/apache/seata/common/NamingServerConstants.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/NamingServerConstants.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/NamingServerConstants.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/session/SessionHolder.java
Outdated
Show resolved
Hide resolved
# Conflicts: # common/src/main/java/org/apache/seata/common/exception/ErrorCode.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The Seata server side, used for initiating registration with the Naming Server and for the storage of Naming Server metadata.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews