Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test : old version(< 0.7.1) client test case for multi-version protocol #6695

Merged
merged 25 commits into from
Jul 30, 2024

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Jul 24, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

old version(< 0.7.1) client test case for Multi-version protocol

Ⅱ. Does this pull request fix one issue?

fixes #6694

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.46%. Comparing base (da9e99b) to head (d0b5a38).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6695   +/-   ##
=========================================
  Coverage     50.46%   50.46%           
  Complexity     5830     5830           
=========================================
  Files          1051     1051           
  Lines         36347    36347           
  Branches       4323     4323           
=========================================
  Hits          18342    18342           
  Misses        16187    16187           
  Partials       1818     1818           

see 3 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 26, 2024
@funky-eyes funky-eyes added the module/test test module label Jul 26, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seata-parent 中没有添加该模块,github上ci压根没有跑起来
The module was not added to Ceata Parente, and Gitub didn't run at all last time

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the type: test test case label Jul 30, 2024
@funky-eyes funky-eyes merged commit a3aa11b into apache:2.x Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/test test module type: test test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-version protocol compatibility feature requires a test collection for < 0.7.1
2 participants