Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fall back to any of available cluster address when query cluster address is empty #6797

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

laywin
Copy link
Contributor

@laywin laywin commented Aug 29, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fall back to any of available cluster address when query cluster address is empty

Ⅱ. Does this pull request fix one issue?

fix: #6790

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@laywin
Copy link
Contributor Author

laywin commented Aug 29, 2024

@funky-eyes PTAL

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.

Project coverage is 52.16%. Comparing base (525d1b9) to head (dec1ec4).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ache/seata/discovery/registry/RegistryService.java 0.00% 18 Missing ⚠️
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% 10 Missing ⚠️
...ery/registry/consul/ConsulRegistryServiceImpl.java 0.00% 2 Missing ⚠️
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 0.00% 2 Missing ⚠️
...overy/registry/nacos/NacosRegistryServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6797      +/-   ##
============================================
- Coverage     52.19%   52.16%   -0.03%     
- Complexity     6310     6312       +2     
============================================
  Files          1067     1067              
  Lines         37278    37303      +25     
  Branches       4427     4430       +3     
============================================
+ Hits          19456    19459       +3     
- Misses        15889    15912      +23     
+ Partials       1933     1932       -1     
Files with missing lines Coverage Δ
...overy/registry/redis/RedisRegistryServiceImpl.java 70.90% <100.00%> (+0.17%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.30% <100.00%> (+0.26%) ⬆️
...overy/registry/nacos/NacosRegistryServiceImpl.java 15.38% <0.00%> (ø)
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.65% <0.00%> (-0.02%) ⬇️
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 11.19% <0.00%> (-0.09%) ⬇️
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% <0.00%> (ø)
...ache/seata/discovery/registry/RegistryService.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@laywin laywin closed this Aug 29, 2024
@laywin laywin reopened this Aug 29, 2024
@laywin laywin closed this Aug 29, 2024
@laywin laywin reopened this Aug 29, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 30, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/discovery discovery module labels Aug 30, 2024
changes/en-us/2.x.md Outdated Show resolved Hide resolved
@laywin laywin closed this Aug 30, 2024
@laywin laywin reopened this Aug 30, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit b0c2bb2 into apache:2.x Aug 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/discovery discovery module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removeOfflineAddressesIfNecessary method may cause the service list to be empty when switching clusters
2 participants