-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports service discovery with Etcd #869
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #869 +/- ##
=============================================
- Coverage 38.29% 37.78% -0.51%
Complexity 1033 1033
=============================================
Files 222 224 +2
Lines 8665 8795 +130
Branches 1051 1063 +12
=============================================
+ Hits 3318 3323 +5
- Misses 4953 5078 +125
Partials 394 394
Continue to review full report at Codecov.
|
...discovery-etcd3/src/main/java/io/seata/discovery/registery/etcd/EtcdRegistryServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Ⅰ. Describe what this PR did
Supports service discovery with Etcd
Ⅱ. Does this pull request fix one issue?
fixes #812
Ⅲ. Why don't you add test cases (unit test/integration test)?
i have done integration test.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews