-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix restTime bug #954
fix restTime bug #954
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #954 +/- ##
=============================================
- Coverage 37.17% 37.11% -0.07%
Complexity 1027 1027
=============================================
Files 225 225
Lines 8906 8905 -1
Branches 1070 1070
=============================================
- Hits 3311 3305 -6
- Misses 5209 5212 +3
- Partials 386 388 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the unit of restTime
is wrong.Should change it to nanosecond
?
why? mills is enough |
The unit between |
yes , i will fix it |
i fix it, please review |
The |
server/src/main/java/io/seata/server/session/GlobalSession.java
Outdated
Show resolved
Hide resolved
fix it PARK_TIMES_BASE_MILLS = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
fix restTime bug
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews