KAFKA-13735/KAFKA-13736: Reenable SocketServerTest.closingChannelWithBufferedReceives and SocketServerTest.remoteCloseWithoutBufferedReceives #11927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d SocketServerTest.remoteCloseWithoutBufferedReceives
dajac
changed the title
dajac
changed the title
guozhangwang
approved these changes
Mar 25, 2022
|
@dajac Thanks a lot! |
|
Oh... no. |
|
@dajac could you revert this commit to re-disable the tests please? |
dajac
added a commit
to dajac/kafka
that referenced
this pull request
Mar 29, 2022
…eives and SocketServerTest.remoteCloseWithoutBufferedReceives (apache#11927)" This reverts commit d706d6c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that those tests have been fixed by b27000e so we can reenable them. I ran the CI 10 times (tests got run 50 times), no failures.
Committer Checklist (excluded from commit message)