Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Demystify rebalance schedule log #12582

Merged
merged 1 commit into from
Sep 1, 2022
Merged

MINOR: Demystify rebalance schedule log #12582

merged 1 commit into from
Sep 1, 2022

Conversation

vvcephei
Copy link
Contributor

@vvcephei vvcephei commented Sep 1, 2022

People have a hard time understanding what's going on with probing rebalances, partly due to cryptic messages like this:

2022-08-31T12:03:29.197+09:00 ..... Requested to schedule probing rebalance for 1661915609131 ms.
2022-08-31T12:04:29.578+09:00 ..... Requested to schedule probing rebalance for 1661915669542 ms.

We should provide a little more context and also encode the timestamp as a readable date/time.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

cadonna
cadonna approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vvcephei !

LGTM!

@vvcephei
Copy link
Contributor Author

vvcephei commented Sep 1, 2022

The java 17 build failed with this unrelated exception:

10:00:43  Execution failed for task ':core:unitTest'.
10:00:43  > Process 'Gradle Test Executor 50' finished with non-zero exit value 1

@vvcephei vvcephei merged commit 8b64a9e into trunk Sep 1, 2022
@vvcephei vvcephei deleted the demystify-rebalance-schedule-log branch September 1, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbejeck bbejeck bbejeck approved these changes

@cadonna cadonna cadonna approved these changes

@ableegoldman ableegoldman Awaiting requested review from ableegoldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vvcephei @bbejeck @cadonna