KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (client side) #12599
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with empty member ID
dajac
changed the title
|
Thanks, I was a little hesitant about the client-side fix since I thought there might be a debugging benefit of having group instance ID in request logs. But I guess this speculative benefit is probably small compared to the cost of seeing the regression in behavior because of the additional validation. |
hachikuji
pushed a commit
that referenced
this pull request
Sep 8, 2022
… with empty member ID (#12599) The consumer group instance ID is used to support a notion of "static" consumer groups. The idea is to be able to identify the same group instance across restarts so that a rebalance is not needed. However, if the user sets `group.instance.id` in the consumer configuration, but uses "simple" assignment with `assign()`, then the instance ID nevertheless is sent in the OffsetCommit request to the coordinator. This may result in a surprising UNKNOWN_MEMBER_ID error. This PR fixes the issue on the client side by not setting the group instance id if the member id is empty (no generation). Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consumer group instance ID is used to support a notion of "static" consumer groups. The idea is to be able to identify the same group instance across restarts so that a rebalance is not needed. However, if the user sets
group.instance.idin the consumer configuration, but uses "simple" assignment withassign(), then the instance ID nevertheless is sent in the OffsetCommit request to the coordinator. This may result in a surprising UNKNOWN_MEMBER_ID error.This PR fixes the issue on the client side by not setting the group instance id if the member id is empty (no generation).
Committer Checklist (excluded from commit message)