Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Move timeline data structures from metadata to server-common #12811

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

dajac
Copy link
Contributor

@dajac dajac commented Nov 2, 2022

We plan to reuse those data structures in the new group coordinator that will be placed in a new module. Knowing this, I propose to move those data structures from metadata to server-common.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac requested a review from cmccabe November 2, 2022 15:07
Copy link
Member

@jsancio jsancio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cmccabe cmccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dajac dajac merged commit bc780c7 into apache:trunk Nov 4, 2022
@dajac dajac deleted the minor-move-timeline-to-server-common branch November 4, 2022 07:52
@dajac dajac added the KIP-848 label Nov 7, 2022
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
…pache#12811)

This path moves the timeline data structures from metadata module to server-common module as those will be used in the new group coordinator.

Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>, Colin Patrick McCabe <cmccabe@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants