MINOR: Handle JoinGroupResponseData.protocolName backward compatibility in JoinGroupResponse #12864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty in JoinGroupResponse
dajac
commented
Nov 16, 2022
Comment on lines
+35
to
+39
| // All versions prior to version 7 do not support nullable | ||
| // string for the protocol name. Empty string should be used. | ||
| if (version < 7 && data.protocolName() == null) { | ||
| data.setProtocolName(""); | ||
| } |
There was a problem hiding this comment.
3 tasks
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…ty in JoinGroupResponse (apache#12864) This is a small refactor extracted from apache#12845. It basically moves the logic to handle the backward compatibility of `JoinGroupResponseData.protocolName` from `KafkaApis` to `JoinGroupResponse`. The patch adds a new unit test for `JoinGroupResponse` and relies on existing tests as well. Reviewers: Justine Olshan <jolshan@confluent.io>, Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor extracted from #12845. It basically moves the logic to handle the backward compatibility of
JoinGroupResponseData.protocolNamefromKafkaApistoJoinGroupResponse.The patch adds a new unit test for
JoinGroupResponseand relies on existing tests as well.Committer Checklist (excluded from commit message)