Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hadoop fs delegation token renewer to empty #6753

Closed
wants to merge 1 commit into from

Conversation

wForget
Copy link
Member

@wForget wForget commented Oct 18, 2024

🔍 Description

Issue References 🔗

Allow delegation tokens to be used and renewed by yarn resourcemanager. (used in proxy user mode of flink engine, address #6383 (comment))

Describe Your Solution 🔧

Set hadoop fs delegation token renewer to empty.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@pan3793 pan3793 added this to the v1.10.0 milestone Oct 18, 2024
@pan3793
Copy link
Member

pan3793 commented Oct 18, 2024

Had an offline discussion with @zhouyifan279, this change is safe, and the changed impl aligns with Spark, merging to master

@pan3793 pan3793 closed this in 535c4f9 Oct 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (85dd5a5) to head (f2e1f0a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../credentials/HadoopFsDelegationTokenProvider.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6753   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42281   42288    +7     
  Branches     5768    5768           
======================================
- Misses      42281   42288    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants