[KYUUBI #6754] Improve the performance of ranger access requests #6758
+194
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Oct 18, 2024
| @@ -34,23 +35,22 @@ case class RuleAuthorization(spark: SparkSession) extends Authorization(spark) { | |||
| val auditHandler = new SparkRangerAuditHandler | |||
| val ugi = getAuthzUgi(spark.sparkContext) | |||
| val (inputs, outputs, opType) = PrivilegesBuilder.build(plan, spark) | |||
| val requests = new ArrayBuffer[AccessRequest]() | |||
| var requests = new HashMap[(AccessResource, AccessType), AccessRequest]() | |||
There was a problem hiding this comment.
Why immutable.HashMap instead of mutable.HashMap is used here?
BTW, Scala 2.13 changed the alias of HashMap from mutable.HashMap to immutable.HashMap, to make the code clear, please write new immutable.HashMap or new mutable.HashMap inline
There was a problem hiding this comment.
and please leave a few comments here to explain the background
There was a problem hiding this comment.
and, was immutable.Map.newBuilder considered?
There was a problem hiding this comment.
- Change to
mutable.HashMap - Added some comments
- I'm not sure if
immutable.Map.newBuilderis better thanmutable.HashMap?
pan3793
reviewed
Oct 18, 2024
| } | ||
|
|
||
| // scalastyle:on | ||
| test("KYUUBI #6754: improve the performance of ranger access requests") { |
There was a problem hiding this comment.
benchmark cases are not expected to run in regular test workflow, I remember we ported Spark benchmark framework, can we write it in that style?
Co-authored-by: Cheng Pan <pan3793@gmail.com>
Co-authored-by: Cheng Pan <pan3793@gmail.com>
wankunde
changed the title
wankunde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6754
Describe Your Solution 🔧
Right now in RuleAuthorization we use an ArrayBuffer to collect access requests, which is very slow because each new PrivilegeObject needs to be compared with all access requests.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Add benchmark
Before
After
Checklist 📝
Be nice. Be informative.