-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MNG-7228] Add IT that ensure nothing "leaks" into installed model (#273
- Loading branch information
Showing
6 changed files
with
260 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7228LeakyModelTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.maven.it; | ||
|
|
||
| import java.io.File; | ||
|
|
||
| import org.apache.commons.io.FileUtils; | ||
| import org.apache.maven.shared.verifier.Verifier; | ||
| import org.apache.maven.shared.verifier.util.ResourceExtractor; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.containsString; | ||
| import static org.hamcrest.Matchers.not; | ||
|
|
||
| class MavenITmng7228LeakyModelTest extends AbstractMavenIntegrationTestCase { | ||
|
|
||
| protected MavenITmng7228LeakyModelTest() { | ||
| // broken: 4.0.0-alpha-3 - 4.0.0-alpha-6 | ||
| super("[,4.0.0-alpha-3),(4.0.0-alpha-6,]"); | ||
| } | ||
|
|
||
| @Test | ||
| void testLeakyModel() throws Exception { | ||
| File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-7228-leaky-model"); | ||
|
|
||
| Verifier verifier = newVerifier(testDir.getAbsolutePath()); | ||
| verifier.setForkJvm(true); | ||
|
|
||
| verifier.addCliArgument("-e"); | ||
| verifier.addCliArgument("-s"); | ||
| verifier.addCliArgument(new File(testDir, "settings.xml").getAbsolutePath()); | ||
| verifier.addCliArgument("-Pmanual-profile"); | ||
|
|
||
| verifier.addCliArgument("install"); | ||
|
|
||
| verifier.execute(); | ||
|
|
||
| verifier.verifyErrorFreeLog(); | ||
|
|
||
| String pom = FileUtils.readFileToString( | ||
| new File(verifier.getArtifactPath("org.apache.maven.its.mng7228", "test", "1.0.0-SNAPSHOT", "pom"))); | ||
|
|
||
| assertThat(pom, containsString("projectProperty")); | ||
| assertThat(pom, not(containsString("activeProperty"))); | ||
| assertThat(pom, not(containsString("manualProperty"))); | ||
|
|
||
| assertThat(pom, containsString("project-repo")); | ||
| assertThat(pom, not(containsString("active-repo"))); | ||
| assertThat(pom, not(containsString("manual-repo"))); | ||
|
|
||
| assertThat(pom, containsString("project-plugin-repo")); | ||
| assertThat(pom, not(containsString("active-plugin-repo"))); | ||
| assertThat(pom, not(containsString("manual-plugin-repo"))); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
core-it-suite/src/test/resources/mng-7228-leaky-model/pom.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>org.apache.maven.its.mng7228</groupId> | ||
| <artifactId>test</artifactId> | ||
| <version>1.0.0-SNAPSHOT</version> | ||
|
|
||
| <properties> | ||
| <projectProperty>project</projectProperty> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>1.7.36</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <repositories> | ||
| <repository> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| </snapshots> | ||
| <id>project-repo</id> | ||
| <url>http://localhost:1234</url> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| </snapshots> | ||
| <id>project-plugin-repo</id> | ||
| <url>http://localhost:1234</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-shade-plugin</artifactId> | ||
| <version>3.5.0</version> | ||
| <configuration> | ||
| <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml</dependencyReducedPomLocation> | ||
| <shadedClassifierName /> | ||
| </configuration> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>shade</goal> | ||
| </goals> | ||
| <phase>package</phase> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> |
104 changes: 104 additions & 0 deletions
104
core-it-suite/src/test/resources/mng-7228-leaky-model/settings.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| <settings> | ||
| <profiles> | ||
| <profile> | ||
| <id>manual-profile</id> | ||
| <repositories> | ||
| <repository> | ||
| <id>manual-repo</id> | ||
| <url>http://localhost:1234</url> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>manual-plugin-repo</id> | ||
| <url>http://localhost:1234</url> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </snapshots> | ||
| </pluginRepository> | ||
| </pluginRepositories> | ||
| <properties> | ||
| <manualProperty>settings</manualProperty> | ||
| </properties> | ||
| </profile> | ||
| <profile> | ||
| <id>active-profile</id> | ||
| <repositories> | ||
| <repository> | ||
| <id>active-repo</id> | ||
| <url>http://localhost:1234</url> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>active-plugin-repo</id> | ||
| <url>http://localhost:1234</url> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| <checksumPolicy>ignore</checksumPolicy> | ||
| <updatePolicy>never</updatePolicy> | ||
| </snapshots> | ||
| </pluginRepository> | ||
| </pluginRepositories> | ||
| <properties> | ||
| <activeProperty>settings</activeProperty> | ||
| </properties> | ||
| </profile> | ||
| </profiles> | ||
| <activeProfiles> | ||
| <activeProfile>active-profile</activeProfile> | ||
| </activeProfiles> | ||
| </settings> |