Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINVOKER-289] - Support for shared invoker's Update-Snapshots Flag #146

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

edwardUL99
Copy link
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MINVOKER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MINVOKER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

A new parameter updateSnapshots has been added to AbstractInvokerMojo which is passed into the shared invoker's InvocationRequest object before being passed into invoker.execute. It can also read the property from invoker.properties file property invoker.updateSnapshots

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Can you try write verification scripts in groovy?

src/it/MINVOKER-289/verify.bsh Outdated Show resolved Hide resolved
src/it/MINVOKER-289/invoker.properties Outdated Show resolved Hide resolved
@edwardUL99
Copy link
Contributor Author

Checks related to an issue with dependency surefire junit is causing mac jdk-8 verify action to fail. The error is as follows:

Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact org.apache.maven.surefire:surefire-junit4:pom:2.12.4 from/to central (https://repo.maven.apache.org/maven2): /Users/runner/work/maven-invoker-plugin/maven-invoker-plugin/target/local-repo/org/apache/maven/surefire/surefire-junit4/2.12.4/surefire-junit4-2.12.4.pom.part (No such file or directory)
 [INFO]   Passed: 1, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for MINVOKER-191-parent 1.0-SNAPSHOT:
[INFO] 
[INFO] MINVOKER-191-parent ................................ SUCCESS [  0.003 s]
[INFO] MINVOKER-191-java-a ................................ SUCCESS [  8.893 s]
[INFO] MINVOKER-191-plugin ................................ SUCCESS [  9.831 s]
[INFO] MINVOKER-191-java-b ................................ FAILURE [  4.251 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  9.940 s (Wall Clock)
[INFO] Finished at: 2022-09-25T21:00:30Z
[INFO] ------------------------------------------------------------------------

Unsure if it is an intermittent problem, or a problem with the code I checked in

@slawekjaranowski
Copy link
Member

surefire-junit4/2.12.4/surefire-junit4-2.12.4.pom.part (No such file or directory)

probably network problems - I will re-run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants