Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to groovy all #62

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Back to groovy all #62

merged 3 commits into from
Aug 9, 2021

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 9, 2021

No description provided.

pzygielo and others added 2 commits August 8, 2021 10:36
Signed-off-by: Olivier Lamy <olamy@apache.org>
pom.xml Outdated Show resolved Hide resolved
@slawekjaranowski
Copy link
Member

I'm not sure if we really need always all groovy dependencies. maybe better will be prepare example how to add more dependencies to plugin executions where is really need. I will check it in next week ...

@pzygielo
Copy link
Contributor

pzygielo commented Aug 9, 2021

I'm not sure if we really need always all groovy dependencies. maybe better will be prepare example how to add more dependencies to plugin executions where is really need. I will check it in next week ...

Consult https://issues.apache.org/jira/browse/MINVOKER-138 which done exactly the opposite 10 years ago.

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Copy link
Member Author

olamy commented Aug 9, 2021

@slawekjaranowski I don't understand what problem do you want to solve? I think it's fine to have full dependencies and easy life. removing that will just break a lot of users!!

@olamy olamy merged commit 0fa63b9 into master Aug 9, 2021
@olamy olamy deleted the back-to-groovy-all branch August 9, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants