Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't use us-east-1 for non-aws s3 instances #2798

Closed
Xuanwo opened this issue Aug 7, 2023 · 2 comments · Fixed by #2812
Closed

fix: Don't use us-east-1 for non-aws s3 instances #2798

Xuanwo opened this issue Aug 7, 2023 · 2 comments · Fixed by #2812
Assignees
@G-XD
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 7, 2023

We currently fallback to us-east-1 for the convenience of our users, but this often results in more issues. Therefore, we propose removing this fallback and instead encouraging users to use detect_region.
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 7, 2023
@G-XD
Copy link
Contributor

G-XD commented Aug 7, 2023

I want try it, please assign me.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 7, 2023

I want try it, please assign me.

Thanks a lot!

@G-XD G-XD mentioned this issue Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-XD G-XD

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(services/s3): remove default region us-east-1 for non-aws s3
2 participants
@Xuanwo @G-XD