Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(services/s3): remove default region us-east-1 for non-aws s3 #2812

Merged
merged 4 commits into from
Aug 8, 2023
Merged

fix(services/s3): remove default region us-east-1 for non-aws s3 #2812

merged 4 commits into from
Aug 8, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Aug 8, 2023 •
edited by Xuanwo
Loading

Fix #2798

@G-XD G-XD requested a review from Xuanwo as a code owner August 8, 2023 06:32
@G-XD G-XD requested a review from PsiACE as a code owner August 8, 2023 06:54
Xuanwo
Xuanwo approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo changed the title Fix(services/s3): remove default region us-east-1 for non-aws s3 fix(services/s3): remove default region us-east-1 for non-aws s3 Aug 8, 2023
@Xuanwo Xuanwo merged commit 779088f into apache:main Aug 8, 2023
32 checks passed
@G-XD G-XD deleted the fix_remove_region_fallback branch August 8, 2023 07:57
@saiintbrisson saiintbrisson mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Don't use us-east-1 for non-aws s3 instances
2 participants
@G-XD @Xuanwo