More javadoc

polaris-service/src/main/java/org/apache/polaris/service/ratelimiting/NoOpRateLimiter.java

@@ -22,7 +22,6 @@
 public class NoOpRateLimiter implements RateLimiter {
   @Override
   public boolean trySpend(double itemCost) {
-    System.out.println("ANDREW: trySpend returning true");
     return true;
   }
 }

polaris-service/src/test/java/org/apache/polaris/service/ratelimiting/AsyncFallbackTest.java

@@ -33,6 +33,11 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 
+/**
+ * Integration test that verifies the timeout behavior for fetching async rate limiters. This is in
+ * its own test class because the Dropwizard app is per test class and there isn't a great way to
+ * allow tests to clear the rate limiter cache.
+ */
 @ExtendWith({
   DropwizardExtensionsSupport.class,
   PolarisConnectionExtension.class,

polaris-service/src/test/java/org/apache/polaris/service/ratelimiting/RateLimitingTest.java

@@ -35,6 +35,7 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 
+/** Main integration tests for rate limiting */
 @ExtendWith({
   DropwizardExtensionsSupport.class,
   PolarisConnectionExtension.class,

polaris-service/src/test/java/org/apache/polaris/service/test/MockClock.java

@@ -18,9 +18,9 @@
  */
 package org.apache.polaris.service.test;
 
-// import io.opentelemetry.sdk.common.Clock;
 import org.apache.polaris.service.ratelimiting.Clock;
 
+/** Mock clock for setting the current time (as perceived by the rate limiter) to anything */
 public class MockClock implements Clock {
   long nanos;
 

polaris-service/src/test/java/org/apache/polaris/service/test/MockRateLimiterFactory.java

@@ -27,6 +27,10 @@
 import org.apache.polaris.service.ratelimiting.RateLimiter;
 import org.apache.polaris.service.ratelimiting.RateLimiterFactory;
 
+/**
+ * Factory that constructs a standard OpenTelemetryRateLimiter but with a mock Clock and an optional
+ * construction delay
+ */
 @JsonTypeName("mock")
 public class MockRateLimiterFactory implements RateLimiterFactory {
   public static MockClock clock = new MockClock();
@@ -49,7 +53,6 @@ public CompletableFuture<RateLimiter> createRateLimiter(String key, Clock clock)
           } catch (InterruptedException e) {
           }
 
-          System.out.println("ANDREW: got here");
           return new OpenTelemetryRateLimiter(
               requestsPerSecond, requestsPerSecond * windowSeconds, MockRateLimiterFactory.clock);
         });