Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up] Trino getting started docker compose #302

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

kevinjqliu
Copy link
Contributor

Description

This PR

  • Renames getting-started/trino/docker-compose-trino.yml to getting-started/trino/docker-compose.yml
  • Fix minor style and grammar issues

Follow up to #42

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Followed README, ran on docker and Trino CLI works

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

@flyrain flyrain merged commit a8a1f6c into apache:main Sep 16, 2024
3 checks passed
@flyrain
Copy link
Contributor

flyrain commented Sep 16, 2024

Thanks @kevinjqliu for the fix.

@kevinjqliu kevinjqliu deleted the kevinjqliu/trino-followup branch September 16, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants