Define configuration store settings on proxy configmap #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to active websockets and while it can be provided via proxy.configData this is more ergonomic for users of the chart.
frankjkelly
added a commit
to frankjkelly/pulsar-helm-chart-1
that referenced
this pull request
Sep 3, 2021
1 task
frankjkelly
added a commit
to frankjkelly/pulsar-helm-chart-1
that referenced
this pull request
Sep 8, 2021
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Sep 10, 2021
Fixes #152 ### Motivation Support prefix in front of port names to abide by Istio protocol rules https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection ### Modifications Support adding a prefix - pulsar -> tcp-pulsar - pulsarssl --> tls-pulsarssl etc
|
@codelipenghui was this closed accidentally? |
|
@josephglanville that was my screw-up - apologies. @codelipenghui can you help? Thanks! |
frankjkelly
added a commit
to frankjkelly/pulsar-helm-chart-1
that referenced
this pull request
Nov 7, 2021
sijie
pushed a commit
that referenced
this pull request
Nov 9, 2021
…t name (#172) Fixes #158 (This is the second PR - see also #162) ### Motivation * All non-standard port-names need a proper protocol prefix to support Istio https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection ### Modifications Add the prefix value before `bookie`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is required to active websockets and while it can be provided via
proxy.configData this is more ergonomic for users of the chart.
Modifications
Added zookeeperServers/configurationStoreServers to proxy config map
Verifying this change