Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8341]Optimize LmqPullRequestHoldService#checkHoldRequest logic #8342

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #8341]Optimize LmqPullRequestHoldService#checkHoldRequest logic #8342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[ISSUE #8341]Optimize LmqPullRequestHoldService#checkHoldRequest logic
  • Loading branch information
@mxsm
mxsm committed Jun 30, 2024
commit 06da43270486d70742415121f33e35436374ce40
2 changes: 1 addition & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/longpolling/LmqPullRequestHoldService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void checkHoldRequest() {
}
if (MixAll.isLmq(topic)) {
ManyPullRequest mpr = pullRequestTable.get(key);
if (mpr == null || mpr.getPullRequestList() == null || mpr.getPullRequestList().isEmpty()) {
if (mpr == null || mpr.isEmpty()) {
pullRequestTable.remove(key);
}
}
Expand Down
Loading