Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8360] Add more test coverage for MQAdminImpl #8361

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Jul 4, 2024

Fixes #8360 .
before:
image
after:
image

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.97%. Comparing base (77d6633) to head (ce2a691).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8361      +/-   ##
=============================================
+ Coverage      43.87%   43.97%   +0.09%     
- Complexity     10646    10663      +17     
=============================================
  Files           1274     1274              
  Lines          88939    88939              
  Branches       11432    11432              
=============================================
+ Hits           39024    39108      +84     
+ Misses         44991    44863     -128     
- Partials        4924     4968      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhouxinyu
Copy link
Member

Nice job, thanks @yx9o

@zhouxinyu zhouxinyu merged commit 77f6415 into apache:develop Jul 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add more test coverage for MQAdminImpl
3 participants