Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Feature: update spans display #215

Merged
merged 2 commits into from
Dec 27, 2018
Merged

Conversation

TinyAllen
Copy link
Member

1.Add top childrens and top slow span.
2.fix windowresize bug.
3.fix time and span tiptip connection.
4.Optimized tree rendering algorithm.

1.Add top childrens and top slow span.
2.fix windowresize bug.
3.fix time and span tiptip connection.
4.Optimized tree rendering algorithm.
@TinyAllen
Copy link
Member Author

wx20181227-000307 2x
wx20181227-000320 2x

@wu-sheng wu-sheng added this to the 6.0.0-GA milestone Dec 26, 2018
@wu-sheng
Copy link
Member

I have two suggestions

  1. TopSlow should be 'Top 5 of slow span', also in this mode, span duration could show itself only, not include children spans. Because you calculate the list by this way.
  2. TopSpan should be 'Top 5 of children span number'. And show the child spans number, only if possible, this is not as important as span duration.

@TinyAllen
Copy link
Member Author

wx20181227-173153 2x 1

@wu-sheng
Copy link
Member

Cool. Like this

@wu-sheng
Copy link
Member

I will write an English and Chinese document for this new page.

@TinyAllen
Copy link
Member Author

😄thanks!

@wu-sheng wu-sheng merged commit 8cce6db into apache:master Dec 27, 2018
@wu-sheng
Copy link
Member

Please send a pull request to sync main repo. @TinyAllen

@TinyAllen TinyAllen deleted the traceupdate branch January 18, 2019 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants