This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Optimization: Local span layer issue #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyuguang
changed the title
TinyAllen
reviewed
Jan 24, 2019
This reverts commit a87dce5.
zhaoyuguang
commented
Jan 24, 2019
| @@ -222,7 +222,12 @@ export default class TraceMap { | |||
| .attr('text-anchor', 'start') | |||
| .attr('fill', d => this.type[d.data.layer]) | |||
| .attr('stroke', d => this.type[d.data.layer]) | |||
| .text(d => d.data.layer); | |||
| .text(d => { | |||
| if(d.data.type == 'Local' && d.data.layer == 'Unknown'){ | |||
There was a problem hiding this comment.
We can't just check unknown, because some RPC plugin may forget to set layer.
wu-sheng
approved these changes
Jan 24, 2019
|
I am merging this. Please submit UI sync pr. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Url: apache/skywalking#2200
Local span layer and layer text is Unknown => 'Local'
Snapshot like this: