Support Backend acts as pure Zipkin collector #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Zipkin receiver | ||
| Zipkin receiver could work in two different mode. | ||
| 1. Tracing mode(default). Tracing mode is that, skywalking OAP acts like zipkin collector, which provide persistence and query, |
There was a problem hiding this comment.
maybe mention the features of the query? I assume this is skywalking queries, not zipkin's https://zipkin.io/zipkin-api/
There was a problem hiding this comment.
Please review the new description again.
- Tracing mode(default). Tracing mode is that, skywalking OAP acts like zipkin collector, fully supports Zipkin v1/v2 formats through HTTP service, also provide persistence and query in skywalking UI. But it wouldn't analysis metric from them. In most case, I suggest you could use this feature, when metrics come from service mesh. Notice, in this mode, Zipkin receiver requires
zipkin-elasticsearchstorage implementation active. Read this to know
how to active.
peng-yongsheng
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peng-yongsheng @adriancole
This PR brings a new feature in SkyWalking. In old
zipkin-skywalkingadaptor, I can't make it 100% production ready(even 90% is hard). But in these months, I work around SkyWalking in service mesh, a pure Zipkin native format collector takes my attention.In SkyWalking/Istio/Envoy solution, we could work in piece very well. And we miss tracing. SkyWalking's agents could work(that is for sure), and at the same time, Zipkin ecosystem could work too, especially, could be used in the production env and sampled based, because it would affect the metric, mesh observability provides 100% traffic/topology metrics.
So, I bring this PR here. Hope you will like this. Used to talk about this in #2044 (6.3.0 feature), I just speed this up.