Query protocol and codebase for log type record #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
added
backend
wu-sheng
requested review from
hanahmily,
liuhaoyang,
JaredTan95,
peng-yongsheng and
TinyAllen
JaredTan95
reviewed
Apr 5, 2019
|
@JaredTan95 I will add it tomorrow. Any object? |
Okay. |
|
@TinyAllen Done. |
TinyAllen
reviewed
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just created
http_access_logmetric, withqueryLogsprotocol, see GraphQL here.@peng-yongsheng @TinyAllen @liuhaoyang @hanahmily
This PR includes codebase only but would use it in any case. In the future, I may want to open a receiver for log collector, such as logstash, etc.
Do you think is it sensible to add traceId too for the future? Including in query protocol.
@TinyAllen
The query protocol is related to UI more, let's add some new page? maybe. Use could query logs through time, (service, instance, endpoint)IDs, status, response time(2xx,4xx,5xx are expected codes)
We need a discussion about this. If others thing traceid should be added, then I will adjust protocol.