Address review comments

apache · Nov 20, 2020 · 2f1081a · 2f1081a
1 parent d82702a
commit 2f1081a
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala b/sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala
@@ -130,7 +130,7 @@ private[ui] class StreamingQueryStatisticsPage(parent: StreamingQueryTab)
       query: StreamingQueryUIData,
       minBatchTime: Long,
       maxBatchTime: Long,
-      jsCollector: JsCollector): NodeBuffer = {
+      jsCollector: JsCollector): Seq[Node] = {
     // This is made sure on caller side but put it here to be defensive
     require(query.lastProgress != null)
     if (query.lastProgress.eventTime.containsKey("watermark")) {
@@ -158,19 +158,18 @@ private[ui] class StreamingQueryStatisticsPage(parent: StreamingQueryTab)
       graphUIDataForWatermark.generateDataJs(jsCollector)
 
       // scalastyle:off
-      new NodeBuffer() &+
-        <tr>
-          <td style="vertical-align: middle;">
-            <div style="width: 160px;">
-              <div><strong>Global Watermark Gap {SparkUIUtils.tooltip("The gap between timestamp and global watermark for the batch.", "right")}</strong></div>
-            </div>
-          </td>
-          <td class="watermark-gap-timeline">{graphUIDataForWatermark.generateTimelineHtml(jsCollector)}</td>
-          <td class="watermark-gap-timeline">{graphUIDataForWatermark.generateHistogramHtml(jsCollector)}</td>
-        </tr>
+      <tr>
+        <td style="vertical-align: middle;">
+          <div style="width: 160px;">
+            <div><strong>Global Watermark Gap {SparkUIUtils.tooltip("The gap between batch timestamp and global watermark for the batch.", "right")}</strong></div>
+          </div>
+        </td>
+        <td class="watermark-gap-timeline">{graphUIDataForWatermark.generateTimelineHtml(jsCollector)}</td>
+        <td class="watermark-gap-timeline">{graphUIDataForWatermark.generateHistogramHtml(jsCollector)}</td>
+      </tr>
       // scalastyle:on
     } else {
-      new NodeBuffer()
+      Seq.empty[Node]
     }
   }