Skip to content

Commit

Permalink
[SPARK-37483][SQL][FOLLOWUP] Rename pushedTopN to PushedTopN and …
Browse files Browse the repository at this point in the history
…improve JDBCV2Suite

### What changes were proposed in this pull request?
This PR fix three issues.
**First**, create method `checkPushedInfo` and `checkSortRemoved` to reuse code.
**Second**, remove method `checkPushedLimit`, because `checkPushedInfo` can cover it.
**Third**, rename `pushedTopN` to `PushedTopN`, so as consistent with other pushed information.

### Why are the changes needed?
Reuse code and let pushed information more correctly.

### Does this PR introduce _any_ user-facing change?
'No'. New feature and improve the tests.

### How was this patch tested?
Adjust existing tests.

Closes #35921 from beliefer/SPARK-37483_followup.

Authored-by: Jiaan Geng <beliefer@163.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 4fe55c5)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
  • Loading branch information
beliefer authored and cloud-fan committed Mar 23, 2022
1 parent 90b01fc commit 737077a
Show file tree
Hide file tree
Showing 2 changed files with 132 additions and 387 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ case class RowDataSourceScanExec(
val pushedTopN =
s"ORDER BY ${seqToString(pushedDownOperators.sortValues.map(_.describe()))}" +
s" LIMIT ${pushedDownOperators.limit.get}"
Some("pushedTopN" -> pushedTopN)
Some("PushedTopN" -> pushedTopN)
} else {
pushedDownOperators.limit.map(value => "PushedLimit" -> s"LIMIT $value")
}
Expand Down
Loading

0 comments on commit 737077a

Please sign in to comment.