Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12682][SQL] Add support for (optionally) not storing tables in hive metadata format #10826

Closed
wants to merge 2 commits into from

Conversation

sameeragarwal
Copy link
Member

This PR adds a new table option (skip_hive_metadata) that'd allow the user to skip storing the table metadata in hive metadata format. While this could be useful in general, the specific use-case for this change is that Hive doesn't handle wide schemas well (see https://issues.apache.org/jira/browse/SPARK-12682 and https://issues.apache.org/jira/browse/SPARK-6024) which in turn prevents such tables from being queried in SparkSQL.

@sameeragarwal sameeragarwal changed the title [SPARK-12682] Add support for (optionally) not storing tables in hive metadata format [SPARK-12682][SQL] Add support for (optionally) not storing tables in hive metadata format Jan 19, 2016
@SparkQA
Copy link

SparkQA commented Jan 19, 2016

Test build #49664 has finished for PR 10826 at commit cae4413.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -323,7 +323,15 @@ private[hive] class HiveMetastoreCatalog(val client: ClientInterface, hive: Hive

// TODO: Support persisting partitioned data source relations in Hive compatible format
val qualifiedTableName = tableIdent.quotedString
val skipHiveMetadata = options.getOrElse("skip_hive_metadata", "false").toBoolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about skipHiveMetadata?

@sameeragarwal
Copy link
Member Author

Thanks @yhuai, all comments addressed.

@yhuai
Copy link
Contributor

yhuai commented Jan 25, 2016

test this please

@sameeragarwal
Copy link
Member Author

jenkins test this please

@SparkQA
Copy link

SparkQA commented Jan 25, 2016

Test build #50014 has finished for PR 10826 at commit 2ce35b1.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Jan 25, 2016

test this please

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50040 has finished for PR 10826 at commit 2ce35b1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Jan 26, 2016

LGTM. Merging to master and branch 1.6.

asfgit pushed a commit that referenced this pull request Jan 26, 2016
… hive metadata format

This PR adds a new table option (`skip_hive_metadata`) that'd allow the user to skip storing the table metadata in hive metadata format. While this could be useful in general, the specific use-case for this change is that Hive doesn't handle wide schemas well (see https://issues.apache.org/jira/browse/SPARK-12682 and https://issues.apache.org/jira/browse/SPARK-6024) which in turn prevents such tables from being queried in SparkSQL.

Author: Sameer Agarwal <sameer@databricks.com>

Closes #10826 from sameeragarwal/skip-hive-metadata.

(cherry picked from commit 08c781c)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@asfgit asfgit closed this in 08c781c Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants