[SPARK-12904][SQL] Strength reduction for integral and decimal literal comparisons #10882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators { | ||
| // fix decimal precision for expressions | ||
| case q => q.transformExpressions( | ||
| decimalAndDecimal.orElse(integralAndDecimalLiteral).orElse(nondecimalAndDecimal)) |
There was a problem hiding this comment.
i broke the previous monolithic decimal precision rule into 2 parts, and then added integralAndDecimalLiteral
|
LGTM |
|
Test build #2447 has finished for PR 10882 at commit
|
|
Test build #49932 has finished for PR 10882 at commit
|
|
Merging this in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements strength reduction for comparing integral expressions and decimal literals, which is more common now because we switch to parsing fractional literals as decimal types (rather than doubles). I added the rules to the existing DecimalPrecision rule with some refactoring to simplify the control flow. I also moved DecimalPrecision rule into its own file due to the growing size.